RFR: 8338544: Dedicated Array class descriptor implementation [v8]

Jorn Vernee jvernee at openjdk.org
Thu Oct 24 14:20:21 UTC 2024


On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang <liach at openjdk.org> wrote:

>> @cl4es discovered that Stack Map generation in ClassFile API uses `componentType` and `arrayType` for `aaload` `aastore` instructions, which are currently quite slow. We can split out array class descriptors from class or interfaces to support faster `arrayType` and `componentType` operations.
>> 
>> Tentative, as I currently have no way to measure the actual impact of this patch on the startup performance; however, this made the `ClassDesc` implementations much cleaner.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix displayName
>   
>   Turns out ArrayClassDesc::displayName was incorrect. Added a test.

Latest version looks good.

P.S. Oh, looks like the tab I had open for this PR wasn't updated. Didn't see it was already merged. All good!

-------------

PR Review: https://git.openjdk.org/jdk/pull/20665#pullrequestreview-2392757564


More information about the core-libs-dev mailing list