Integrated: 8341566: Add Reader.of(CharSequence)
Markus KARG
duke at openjdk.org
Thu Oct 24 14:38:23 UTC 2024
On Sat, 5 Oct 2024 16:32:39 GMT, Markus KARG <duke at openjdk.org> wrote:
> This Pull Requests proposes an implementation for [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new method `public static Reader Reader.of(CharSequence)` will return an anonymous, non-synchronized implementation of a `Reader` for each kind of `CharSequence` implementation. It is optimized for `String`, `StringBuilder`, `StringBuffer` and `CharBuffer`.
>
> In addition, this Pull Request proposes to replace the implementation of `StringReader` to become a simple synchronized wrapper around `Reader.of(CharSequence)` for the case of `String` sources. To ensure correctness, this PR...
> * ...simply moved the **original code** of `StringBuilder` to become the de-facto implementation of `Reader.of()`, then stripped synchronized from it on the left hand, but kept just a synchronized wrapper on the right hand. Then added a `switch` for optimizations within the original code, at the exact location where previously just an optimization for `String` lived in.
> * ...added tests for all methods (`Of.java`), and applied that test upon the modified `StringBuilder`.
>
> Wherever new JavaDocs were added, existing phrases from other code locations have been copied and adapted, to best match the same wording.
This pull request has now been integrated.
Changeset: 3c14c2ba
Author: Markus KARG <markus at headcrashing.eu>
Committer: Chen Liang <liach at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3c14c2babbdfb46a77636ed80e083ef2f8be2b45
Stats: 385 lines in 3 files changed: 338 ins; 36 del; 11 mod
8341566: Add Reader.of(CharSequence)
Reviewed-by: rriggs, jpai, liach, alanb
-------------
PR: https://git.openjdk.org/jdk/pull/21371
More information about the core-libs-dev
mailing list