RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v3]

[Dan Heidinga]

On Wed, 23 Oct 2024 04:46:51 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & Linking](https://openjdk.org/jeps/483).
>> 
>> ----
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https://github.com/openjdk/jdk/pull/20517
>> - https://github.com/openjdk/jdk/pull/20843
>> - https://github.com/openjdk/jdk/pull/20958
>> - https://github.com/openjdk/jdk/pull/20959
>> - https://github.com/openjdk/jdk/pull/21049
>> - https://github.com/openjdk/jdk/pull/21143
>
> Ioi Lam has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - fixed test failure with "jtreg -Dtest.dynamic.cds.archive=true ..."
>  - simplified the archiving of cpCache::resolved_references() -- we rely on AOTConstantPoolResolver::is_indy_resolution_deterministic() to do the filtering before indys are linked; there is no need to try to undo the resolved_references afterwards
>  - Fixed bug where the BSM oops for resolved indies are not archived

Looks good!

src/hotspot/share/cds/aotClassLinker.cpp line 156:

> 154:         ResourceMark rm;
> 155:         log_warning(cds, aot, link)("%s cannot be aot-linked because it nest host is not aot-linked", ik->external_name());
> 156:         return false;

This is a good find!  Just to note - the same kind of check isn't required for PermittedSubclasses as the class granting permission to be a subclass is necessarily already loaded as one of our supers.

-------------

Marked as reviewed by heidinga (no project role).

PR Review: https://git.openjdk.org/jdk/pull/21642#pullrequestreview-2390446370
PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1815035125