RFR: 8342958: Use jvmArgs consistently in microbenchmarks

Jorn Vernee jvernee at openjdk.org
Thu Oct 24 17:41:06 UTC 2024


On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM reasonable or necessary flags, but when deploying and running micros we often want to add or replace flags to tune to the machine, test different GCs, etc. The inconsistent use of the different `jvmArgs` options make it error prone, and we've had a few recent cases where we've not been testing with the expected set of flags. 
> 
> This PR suggests using `jvmArgs` consistently. I think this aligns with the intuition that when you use `jvmArgsAppend/-Prepend` intent is to add to a set of existing flags, while if you supply `jvmArgs` intent is "run with these and nothing else". Perhaps there are other opinions/preferences, and I don't feel strongly about which to consolidate to as long as we do so consistently. One argument could be made to consolidate on `jvmArgsAppend` since that one is (likely accidentally) the current most popular (143 compared to 59 `jvmArgsPrepend` and 18 `jvmArgs`).

Overall I like the idea. I took a look at the `foreign` benchmarks in particular, and don't see any issues with them.

-------------

Marked as reviewed by jvernee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21683#pullrequestreview-2393339018


More information about the core-libs-dev mailing list