RFR: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Oct 25 02:15:03 UTC 2024
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - It is not clear on which macOS versions codesign fails if application bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG or DMG cannot be generated if signing fails. Exit code of jpackage is ignored, but generated application image will be checked for additional content.
> - This change is for macOS only.
> - Previous implementation of test (forcing expected exist code to 1) was not doing anything useful, since we never checked if additional content was copied or not.
The test does nothing on OSX, right? We just run jpackage and don't verify the output. What is the point then?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21698#issuecomment-2436667340
More information about the core-libs-dev
mailing list