RFR: 8340133: Add concise usage message to the java executable [v5]

[Jan Lahoda]

On Thu, 24 Oct 2024 10:10:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleaning up the concise message:
>>   - using 2 spaces instead of 4,
>>   - rewording the "for more use --help" part of the message as suggested to avoid the word "launcher".
>
> src/java.base/share/native/libjli/java.c line 546:
> 
>> 544: 
>> 545:     /* If the user specified neither a class name nor a JAR file */
>> 546:     if (printUsageKind != HELP_NONE) {
> 
> Is the state check for `what` and `mode` no longer needed here?

The idea was that `printUsageKind` should replace that - specifically, `HELP_CONCISE` should be equivalent to the original `what == 0 || mode == LM_UNKNOWN`. The code is a bit cryptic, so I hope I managed to achieve that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21411#discussion_r1816473575