RFR: 8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices [v4]
Brian Burkhalter
bpb at openjdk.org
Fri Oct 25 22:14:43 UTC 2024
On Fri, 25 Oct 2024 18:09:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8341666: Fix Windows oversight
>
> src/java.base/share/classes/java/io/FileInputStream.java line 86:
>
>> 84:
>> 85: // This field indicates whether the position0() or skip0() may be
>> 86: // invoked without encountering an illegal seek exception.
>
> You might be update this to say that it indicates if the file is regular file as some operations need the current position and to seek. Otherwise the src changes looks good.
Updated in 98f918a.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21673#discussion_r1817414561
More information about the core-libs-dev
mailing list