RFR: 8342642: Class loading failure due to archived map issue in ModuleLoaderMap.Mapper

[Alan Bateman]

On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

> Moved from https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
> 
> Please review the fix that uses String type for the mapped value in ModuleLoaderMap.Mapper map (Map<String, String>). Please see details in https://bugs.openjdk.org/browse/JDK-8342642, thanks.
> 
> Existing comment threads from closed https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2436358591
> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2437465648
> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2438567642
> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2436262114
> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2437501231

src/java.base/share/classes/jdk/internal/module/ModuleLoaderMap.java line 58:

> 56: 
> 57:         /**
> 58:          * Map from module to a class loader name. The name is resolved to the

Would you mind adjusting this to "Map from module name to class loader name"? Otherwise switching this to using a string is okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21722#discussion_r1818842284