RFR: 8343178: Test BasicTest.java javac compile fails cannot find symbol

[Jaikiran Pai]

On Tue, 29 Oct 2024 03:03:17 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The test `tools/jpackage/share/jdk/jpackage/tests/BasicTest.java` javac compile fails `cannot find symbol TKit.assertPathNotEmptyDirectory` after JDK-8343178. I think we should use `TKit.assertDirectoryNotEmpty` instead of `TKit.assertPathNotEmptyDirectory`.
> The change has been verified locally on linux-x64, test-fix only , no risk.

Marked as reviewed by jpai (Reviewer).

Hello @sendaoYan,

> Hi all, The test `tools/jpackage/share/jdk/jpackage/tests/BasicTest.java` javac compile fails `cannot find symbol TKit.assertPathNotEmptyDirectory` after JDK-8343178.

I think you meant https://bugs.openjdk.org/browse/JDK-8343101.

I don't have prior knowledge of this area but the change looks OK and trivial to me and would fix a compilation error in the tests.

@sashamatveev or @alexeysemenyukoracle, do you think this looks OK?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21750#pullrequestreview-2400717800
PR Comment: https://git.openjdk.org/jdk/pull/21750#issuecomment-2443213483