RFR: 8342642: Class loading failure due to archived map issue in ModuleLoaderMap.Mapper [v2]

[Aleksey Shipilev]

On Mon, 28 Oct 2024 16:41:56 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Moved from https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>> 
>> Please review the fix that uses String type for the mapped value in ModuleLoaderMap.Mapper map (Map<String, String>). Please see details in https://bugs.openjdk.org/browse/JDK-8342642, thanks.
>> 
>> Existing comment threads from closed https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2436358591
>> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2437465648
>> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2438567642
>> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2436262114
>> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2437501231
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust comment.

Looks fine, a minor nit:

src/java.base/share/classes/jdk/internal/module/ModuleLoaderMap.java line 92:

> 90:             } else if (PLATFORM_LOADER_NAME.equals(loader)) {
> 91:                 return PLATFORM_CLASSLOADER;
> 92:             } else { // BOOT_LOADER_INDEX

Drop the `// BOOT_LOADER_INDEX`?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21722#pullrequestreview-2402478363
PR Review Comment: https://git.openjdk.org/jdk/pull/21722#discussion_r1821160582