RFR: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions [v2]
Alexander Matveev
almatvee at openjdk.org
Tue Oct 29 21:56:05 UTC 2024
On Tue, 29 Oct 2024 16:06:32 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Change suffixes produced by `TKit.createUniqueFileName()` function from `.<NUM>` to `-<NUM>` (e.g.: from `.0` to `-0`).
>> Apple's `codesign` tool can't sign directories with periods in their names as it interprets them as bundles. Directories produced by `TKit.createUniqueFileName()` may end up in an app image and become a subject for signing if used with `--app-content` jpackage parameter
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>
> Rework test to copy `--app-content` into "Contents/Resources" folder instead of "Contents" on OSX.
Looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21741#pullrequestreview-2403149641
More information about the core-libs-dev
mailing list