RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v12]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Tue Oct 29 22:19:22 UTC 2024
On Mon, 28 Oct 2024 21:07:47 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Object::wait
>
> src/hotspot/cpu/x86/continuationFreezeThaw_x86.inline.hpp line 146:
>
>> 144: // Make sure that locals is already relativized.
>> 145: DEBUG_ONLY(Method* m = f.interpreter_frame_method();)
>> 146: DEBUG_ONLY(int max_locals = !m->is_native() ? m->max_locals() : m->size_of_parameters() + 2;)
>
> What is the + 2 for? Is the check for is_native because of wait0? Please add a comment what this line is doing.
It's for the 2 extra words for native methods (temp oop/result handler). Added comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1821591143
More information about the core-libs-dev
mailing list