RFR: 8343040: Clean up references to JRE in the launcher code [v2]

Jaikiran Pai jpai at openjdk.org
Wed Oct 30 01:52:44 UTC 2024


On Wed, 30 Oct 2024 01:49:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which cleans up references to "JRE" from the launcher's code?
>> 
>> No functional changes have been introduced in this change.
>> 
>> No new tests have been introduced and existing tests in tier1, tier2 and tier3 continue to pass in our CI against Linux, macosx and Windows.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's review - fix code comment about Microsoft C Runtime Library

src/java.base/windows/native/libjli/java_md.c line 360:

> 358:     /*
> 359:      * The Microsoft C Runtime Library needs to be loaded first. A copy is
> 360:      * assumed to be present within the JDK. If it is not found there

I decided not to explicitly mention the "bin" directory here and let that be explained in the implementation of the `LoadMSVCRT()` function itself. If you think we should include the "bin" part here too, then let me know.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21704#discussion_r1821744638


More information about the core-libs-dev mailing list