RFR: 8341260: Add Float16 to jdk.incubator.vector [v10]

Raffaello Giulietti rgiulietti at openjdk.org
Wed Oct 30 14:12:15 UTC 2024


On Wed, 30 Oct 2024 05:12:18 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 504:
>> 
>>> 502:                     // without the period.
>>> 503:                     hexSignificand.append(s.substring(digitStart,      periodIndex));
>>> 504:                     hexSignificand.append(s.substring(periodIndex + 1, pIndex));
>> 
>> Suggestion:
>> 
>>                     hexSignificand.append(s, digitStart, periodIndex);
>>                     hexSignificand.append(s, periodIndex + 1, pIndex);
>
> Good refactoring; thanks for the suggestion.

The credit goes to my IDE ;-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1822722888


More information about the core-libs-dev mailing list