RFR: 8336267: Method and Constructor signature parsing can be shared on the root object [v4]

Mandy Chung mchung at openjdk.org
Wed Oct 30 16:23:09 UTC 2024


On Wed, 30 Oct 2024 10:02:22 GMT, Chen Liang <liach at openjdk.org> wrote:

>> A straightforward optimization, to share the signature parsing of method, constructor, and field between the root and the copied objects, like how method handle accessors are shared.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missed field

Looks good.

src/java.base/share/classes/java/lang/reflect/Method.java line 97:

> 95:     private @Stable MethodAccessor methodAccessor;
> 96:     private int hash; // not shared right now, eligible if expensive
> 97:     // End shared states

Suggestion:

    // End shared states
    private int hash; // not shared right now, eligible if expensive

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20179#pullrequestreview-2405522402
PR Review Comment: https://git.openjdk.org/jdk/pull/20179#discussion_r1822978696


More information about the core-libs-dev mailing list