RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v22]

Dean Long dlong at openjdk.org
Wed Oct 30 23:25:47 UTC 2024


On Wed, 30 Oct 2024 22:11:38 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> src/hotspot/share/runtime/continuation.hpp line 50:
>> 
>>> 48: class JavaThread;
>>> 49: 
>>> 50: // should match Continuation.PreemptStatus() in Continuation.java
>> 
>> As far as I can tell, these enum values still don't match the Java values.  If they need to match, then maybe there should be asserts that check that.
>
> `PreemptStatus` is meant to be used with `tryPreempt()` which is not implemented yet, i.e. there is no method yet that maps between these values and the PreemptStatus enum. The closest is `Continuation.pinnedReason` which we do use. So if you want I can remove the reference to PreemptStatus and use pinnedReason instead.

Yes, that would be better for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1823584967


More information about the core-libs-dev mailing list