RFR: 8343293: Remove the check for <apphome>/jre/lib/libjava.dylib from the launcher's java_md_macosx.m
Brian Burkhalter
bpb at openjdk.org
Thu Oct 31 01:55:28 UTC 2024
On Wed, 30 Oct 2024 14:27:03 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which cleans up a leftover code from the launcher's java_md_macosx.m file?
>
> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the launcher code to remove checks for `<apphome>/jre/lib/` when determining the JDK installation root. Those changes were done in the Unix and Windows files and the macosx one got left out, likely due to an oversight.
>
> The commit in this PR removes that leftover code. No new tests have been added and existing tier1, tier2, tier3 tests continue to pass.
Looks fine to me, especially given the testing cited, but this is not my area so I bumped the reviewer count to 2.
-------------
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21789#pullrequestreview-2406800926
More information about the core-libs-dev
mailing list