RFR: 8325089: jpackage utility creates an "infinite", undeleteable directory tree [v12]

[Alexey Semenyuk]

On Thu, 31 Oct 2024 00:53:19 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Bugfix
>>  - Rename DirectoryContentVerifier.equals() in DirectoryContentVerifier.match() to fix name conflict with Object.equals()
>
> test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java line 57:
> 
>> 55:         MATCH(DirectoryContentVerifier::match),
>> 56:         CONTAINS(DirectoryContentVerifier::contains),
>> 57:         ;
> 
> Should ";" be at the end of `CONTAINS(...)` and remove ","?

I'd prefer to keep it as is unless you strongly dislike it. The benefit is that it makes clean diffs when items added/removed from the enum.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21550#discussion_r1823765094