RFR: 8343019: Primitive caches must use boxed instances from the archive [v4]

Aleksey Shipilev shade at openjdk.org
Thu Oct 31 07:48:41 UTC 2024


On Wed, 30 Oct 2024 18:08:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change InternalErrors to asserts
>
> src/java.base/share/classes/java/lang/Integer.java line 966:
> 
>> 964:                 // Otherwise, the identity checks between archived Integers and
>> 965:                 // runtime-cached Integers would fail.
>> 966:                 int archivedIdx = (archivedCache == null) ? 0 : archivedCache.length;
> 
> I think the name of `archiveIdx` isn't clear. How about `archivedSize`?

Yes, we can do `archivedSize`. Done in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21737#discussion_r1824010416


More information about the core-libs-dev mailing list