RFR: 8328877: [JNI] The JNI Specification needs to address the limitations of integer UTF-8 String lengths [v2]

David Holmes dholmes at openjdk.org
Mon Sep 2 09:50:18 UTC 2024


On Mon, 2 Sep 2024 09:05:17 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Exclude test on 32-bit
>
> Deprecating the existing function and introducing the new function looks okay.
> 
> The test is really 3 tests in one (GetStringUTFLength returning a truncated size, GetStringUTFLength with -Xcheck:jni prints a warning, and GetStringUTFLengthAsLong returns the long size). Personally I would have done this as 3 test cases rather in one launch with -Xcheck:jni but that's your choice.

Thanks for the review @AlanBateman . I like the test the way it is.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20784#issuecomment-2324302820


More information about the core-libs-dev mailing list