RFR: 8339168: Optimize ClassFile Util slotSize [v3]

Claes Redestad redestad at openjdk.org
Tue Sep 3 13:13:21 UTC 2024


On Tue, 3 Sep 2024 13:09:37 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> A small optimization to improve the performance of jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestion from @liach & @cl4es

src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 256:

> 254: 
> 255:     public static int slotSize(ClassDesc desc) {
> 256:         return isDoubleSlot(desc) ? 2 : 1;

No, I meant for this to be implemented in a new method, `paramSlotSize`, then call that instead of `slotSize` in the places where that's safe.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20747#discussion_r1742038452


More information about the core-libs-dev mailing list