RFR: 8339487: ProcessHandleImpl native exceptions - include message text and last error information

[Matthias Baesken]

On Tue, 3 Sep 2024 14:09:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> When running jtreg test java/lang/ProcessHandle/PermissionTest.java on macOS, a few times this error occurs :
> 
> java.lang.RuntimeException: Cannot allocate memory
>        at java.base/java.lang.ProcessHandleImpl.getProcessPids0(Native Method)
>        at java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:456)
>        at java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:434)
>        at PermissionTest.childrenWithPermission(PermissionTest.java:84)
>        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>        at java.base/java.lang.reflect.Method.invoke(Method.java:573)
>        at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
>        at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
>        at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
>        at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
>        at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
>        at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
>        at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
>        at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
>        at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
> 
> 
> Probably sysctl fails here, but it is not fully clear; it would help to change the exception so that the standard text is shown too in the exception message.

I looked into the failures we observed on macOS in the last few months and they all look similar 

test PermissionTest.allProcessesWithPermission(): failure
java.lang.RuntimeException: Cannot allocate memory
	at java.base/java.lang.ProcessHandleImpl.getProcessPids0(Native Method)
	at java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:456)
	at java.base/java.lang.ProcessHandle.allProcesses(ProcessHandle.java:199)
	at PermissionTest.allProcessesWithPermission(PermissionTest.java:78)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at org.testng.TestRunner.privateRun(TestRunner.java:764)
	at org.testng.TestRunner.run(TestRunner.java:585)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
	at org.testng.SuiteRunner.run(SuiteRunner.java:286)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
	at org.testng.TestNG.runSuites(TestNG.java:1069)
	at org.testng.TestNG.run(TestNG.java:1037)
	at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:102)
	at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:58)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
	at java.base/java.lang.Thread.run(Thread.java:1583)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20839#issuecomment-2326851400