RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v20]

Shaojin Wen swen at openjdk.org
Wed Sep 4 13:30:21 UTC 2024


On Wed, 4 Sep 2024 12:01:37 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Use fast path for ascii characters 1 to 127 to improve the performance of writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   from @cl4es 's suggestion

https://github.com/wenshao/jdk/actions/runs/10701158902/job/29667402594

runtime/cds/DeterministicDump.java

java.lang.RuntimeException: File content different at byte #4, b0 = -45, b1 = -22
	at DeterministicDump.compare(DeterministicDump.java:114)
	at DeterministicDump.doTest(DeterministicDump.java:66)
	at DeterministicDump.main(DeterministicDump.java:42)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:573)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
	at java.base/java.lang.Thread.run(Thread.java:1575)


macOS aarch64 build fails, but often works fine after re-running. Should I fix this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20772#issuecomment-2329051019


More information about the core-libs-dev mailing list