RFR: 8334048: -Xbootclasspath can not read some ZIP64 zip files [v3]

[fitzsim]

On Wed, 4 Sep 2024 11:45:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> fitzsim has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   BootClassPathZipFileTest: Switch to createClassBytes, createZip static functions
>
> Not an expert in this area, so just a drive-by review.

Thank you for reviewing @jerboaa.  I will work on implementing your suggestions.

> test/hotspot/jtreg/runtime/BootClassAppendProp/BootClassPathZipFileCreator.java line 76:
> 
>> 74:             env.put("forceZIP64End", "true");
>> 75:         }
>> 76:         Path zip = Paths.get(System.getProperty("user.dir"), type + ".zip");
> 
> Should we use `test.classes` (i.e. `System.getProperty("test.classes", System.getProperty("user.dir")`) dir for those transient files?

Will do, see below.

> test/hotspot/jtreg/runtime/BootClassAppendProp/BootClassPathZipFileTest.java line 49:
> 
>> 47:         // the ZIP file not existing is the same as the ZIP file not being
>> 48:         // readable, that is, ClassNotFoundException on CLASS_NAME.
>> 49:         Path zipPath = Paths.get(System.getProperty("user.dir"), args[0]);
> 
> `test.classes` here as well.

I re-read the jtreg tag-spec documentation about this and I agree this is the most appropriate place for these files.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19678#issuecomment-2329307051
PR Review Comment: https://git.openjdk.org/jdk/pull/19678#discussion_r1743966886
PR Review Comment: https://git.openjdk.org/jdk/pull/19678#discussion_r1743966979