RFR: 8337753: Target class of upcall stub may be unloaded [v3]
Amit Kumar
amitkumar at openjdk.org
Wed Sep 4 16:49:26 UTC 2024
On Wed, 4 Sep 2024 10:00:47 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add RISC-V as target platform
>
> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3062:
>
>> 3060: StubCodeMark mark(this, "StubRoutines", "upcall_stub_load_target");
>> 3061: address start = __ pc();
>> 3062: __ save_return_pc();
>
> @offamitkumar: Is saving and restoring the return_pc needed? Isn't in preserved by load_heap_oop?
I looked into it, but couldn't find out. But I remove the `save_return_pc` & `restore_return_pc` and everything seems fine. So maybe we can remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20479#discussion_r1744116982
More information about the core-libs-dev
mailing list