RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v20]
Shaojin Wen
swen at openjdk.org
Wed Sep 4 23:17:00 UTC 2024
On Wed, 4 Sep 2024 18:09:31 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> from @cl4es 's suggestion
>
> test/jdk/java/lang/String/CountNonZeroAscii.java line 35:
>
>> 33: * @modules java.base/jdk.internal.access
>> 34: * @summary test latin1 String countNonZeroAscii
>> 35: * @run testng/othervm -XX:+CompactStrings CountNonZeroAscii
>
> You are using the `testng` driver for a `main` test. I can probably fix it quickly.
Is it recommended to change it to this?
/*
* @test
* @modules java.base/jdk.internal.access
* @summary test latin1 String countNonZeroAscii
* @run main/othervm -XX:+CompactStrings CountNonZeroAscii
* @run main/othervm -XX:-CompactStrings CountNonZeroAscii
*/
``
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20772#discussion_r1744609167
More information about the core-libs-dev
mailing list