RFR: 8339531: Improve performance of MemorySegment::mismatch [v3]

Per Minborg pminborg at openjdk.org
Thu Sep 5 12:09:08 UTC 2024


On Thu, 5 Sep 2024 11:15:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into mismatch-performance2
>>  - Move fill to SegmentBulkOperations
>>  - Add system property and improve benchmark
>>  - Update src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java
>>    
>>    Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>
>>  - Remove temp methods
>>  - Clean up
>>  - Update comment
>>  - Merge branch 'master' into mismatch-performance2
>>  - Create a separate class for segment bulk operations
>>  - Add Java implementation of MS::mismatch
>
> test/micro/org/openjdk/bench/java/lang/foreign/Mismatch.java line 87:
> 
>> 85:     }
>> 86: 
>> 87:     @Fork(value = 3, jvmArgsAppend = {"-Djava.lang.foreign.native.threshold.power.mismatch=31"})
> 
> Should we add similar variants to the fill benchmarks?

Good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20848#discussion_r1745340173


More information about the core-libs-dev mailing list