RFR: 8333446: Add tests for hierarchical container support [v6]
Severin Gehwolf
sgehwolf at openjdk.org
Fri Sep 6 12:56:53 UTC 2024
On Fri, 30 Aug 2024 11:05:24 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Add root check for SystemdMemoryAwarenessTest.java
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Add Whitebox check for host cpu
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Fix comments
>> - 8333446: Add tests for hierarchical container support
>
> Looking through the coding it looks more or less okay to me; but if you really need to run it under user 'root' I think we will not have so much use for this in our test environments because we use other test users.
> Not saying that this is a very bad thing, maybe it is just the way it is, that 'root' is needed ?
Thank you for the review, @MBaesken!
@zzambers OK for you as well?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19530#issuecomment-2333989946
More information about the core-libs-dev
mailing list