RFR: 8339683: Simplify class data generation in InvokerBytecodeGenerator [v2]

Fri Sep 6 22:22:19 UTC 2024

On Fri, 6 Sep 2024 19:55:38 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Elide duplicate field CP entry creation, and reuse elements in the field CP entry for field generation.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Do not try to classdata non-live lambda forms in pre-generation

Right, for pre-generated forms we don't need any tricks to keep the form and the implementation class alive together as these methods are added to the Holder class. So this is good. 

Maybe we should assert against attempting to add classData fields to a pre-generated LF? 

Which class name is wrong? I don't see it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20896#issuecomment-2334883135