Integrated: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message

[Matthias Baesken]

On Tue, 3 Sep 2024 14:09:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> When running jtreg test java/lang/ProcessHandle/PermissionTest.java on macOS, a few times this error occurs :
> 
> java.lang.RuntimeException: Cannot allocate memory
>        at java.base/java.lang.ProcessHandleImpl.getProcessPids0(Native Method)
>        at java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:456)
>        at java.base/java.lang.ProcessHandleImpl.children(ProcessHandleImpl.java:434)
>        at PermissionTest.childrenWithPermission(PermissionTest.java:84)
>        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>        at java.base/java.lang.reflect.Method.invoke(Method.java:573)
>        at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
>        at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
>        at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
>        at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
>        at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
>        at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
>        at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
>        at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
>        at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
> 
> 
> Probably sysctl fails here, but it is not fully clear; it would help to change the exception so that the standard text is shown too in the exception message.

This pull request has now been integrated.

Changeset: 4ff72dc5
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4ff72dc57e65e99b129f0ba28196994edf402018
Stats:     29 lines in 2 files changed: 11 ins; 1 del; 17 mod

8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message

Reviewed-by: alanb, lucy, rriggs

-------------

PR: https://git.openjdk.org/jdk/pull/20839