RFR: 8339677: [vectorapi] YYYXXXVector::withLaneHelper and laneHelper should use Double::doubleToRawLongBits/Float::floatToRawIntBits

Paul Sandoz psandoz at openjdk.org
Mon Sep 9 15:52:05 UTC 2024


On Sat, 7 Sep 2024 04:47:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch fixes an issue where we mistakenly use `Double::doubleToLongBits` in `DoubleXXXVector::withLaneHelper` and `DoubleXXXVector::laneHelper`. We should use the raw bit version instead.
>> 
>> Please kindly review, thanks very much.
>
> Hello @merykitty, there are several files in this PR with just copyright year updates and no other change. Is that intentional?

> @jaikiran All the `YYYXXXVector.java` files are generated from `X-VectorBits.java.template`, so if I change some of them all the others will get their copyright year updated as well.

Yes its an unfortunately side-effect of generation from template files. (There is a issue/task to integrate this generation into the build system, but given we are incubating there is less urgency to do this.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20895#issuecomment-2338478224


More information about the core-libs-dev mailing list