RFR: 8339686: java/foreign/TestMappedHandshake.java fails with assert(depth < max_critical_stack_depth) failed: can't have more than 10 critical frames [v2]

Alan Bateman alanb at openjdk.org
Mon Sep 9 18:52:05 UTC 2024


On Mon, 9 Sep 2024 12:59:15 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Drop spurious change
>
> src/java.base/share/classes/jdk/internal/access/foreign/MappedMemoryUtilsProxy.java line 9:
> 
>> 7:  * This allows to avoid pesky initialization issues in the middle of memory mapped scoped methods.
>> 8:  */
>> 9: public interface MappedMemoryUtilsProxy {
> 
> We should probably try to consolidate this and `UmapperProxy` - I think it can be done, but it requires deeper surgery than I was willing to do in this PR.

Although this proxy class may be temporarily, I'll think you'll need to put a copyright header on it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20914#discussion_r1750760987


More information about the core-libs-dev mailing list