RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]
David Holmes
dholmes at openjdk.org
Tue Sep 10 11:10:38 UTC 2024
On Tue, 10 Sep 2024 11:07:30 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>>
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> update JImageToolTest too
LGTM!
Thanks for cleaning this up.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2292111663
More information about the core-libs-dev
mailing list