RFR: 8339538: Wrong timeout computations in DnsClient [v5]
Aleksei Efimov
aefimov at openjdk.org
Tue Sep 10 18:41:41 UTC 2024
On Tue, 10 Sep 2024 17:54:30 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
>> If I'm not mistaken here it's `Math.clamp(long, long, long)` which is called - because `timeout * (1L << retry)` is a long. We could make it more obvious by using `0L` instead of `0` too.
>
> thanks for the clarification ... yes indeed, I didn't see the 1L as the original was (timeout * (1 << retry))
> BUT I should have read the comment more precisely(small screens and no glasses !!)
Changed `0` -> `0L` to make it more obvious
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1752523532
More information about the core-libs-dev
mailing list