RFR: 8339538: Wrong timeout computations in DnsClient [v5]

[Aleksei Efimov]

On Tue, 10 Sep 2024 14:54:58 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Measure time the caller spent waiting. Simplify timeoutLeft computation
>
> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 479:
> 
>> 477:                     long elapsedMillis = TimeUnit.NANOSECONDS
>> 478:                                                  .toMillis(System.nanoTime() - start);
>> 479:                     timeoutLeft = pktTimeout - Math.clamp(elapsedMillis, 0, Integer.MAX_VALUE);
> 
> Suggestion:
> 
>                     timeoutLeft = pktTimeout - elapsedMillis;
> 
> Now that timeoutLeft is a long we have no reason to clamp at Integer.MAX_VALUE.

Thanks fixed in [3abb782](https://github.com/openjdk/jdk/pull/20892/commits/3abb782904cf80d2ed5da70266cdfeea05b1bd2f)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1752523889