RFR: 8339874: Avoid duplicate checking of trailing slash in ZipFile.getZipEntry [v4]
Eirik Bjørsnøs
eirbjo at openjdk.org
Wed Sep 11 08:39:06 UTC 2024
On Tue, 10 Sep 2024 19:39:24 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 161:
>
>> 159: }
>> 160:
>> 161: protected boolean hasTrailingSlash(byte[] a, int end) {
>
> Can you explain the need for this
See other comment to Claes: Since UTF8ZipCoder.compare is now the only caller of this method, it can be made private.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20939#discussion_r1753611453
More information about the core-libs-dev
mailing list