RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 11 09:10:12 UTC 2024


On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update JImageToolTest too

Looks good to me.

It could be good to remove `@author` tags from all the modified tests.

test/jdk/java/beans/Introspector/Test5102804.java line 28:

> 26:  * @bug 5102804
> 27:  * @summary Tests memory leak
> 28:  * @author Sergey Malenkov

Could you also remove the `@author` tag?

test/jdk/java/beans/Introspector/Test8027905.java line 30:

> 28:  * @bug 8027905
> 29:  * @summary Tests that GC does not affect a property type
> 30:  * @author Sergey Malenkov

Could you also remove the `@author` tag?

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2296140348
PR Review Comment: https://git.openjdk.org/jdk/pull/20930#discussion_r1753703304
PR Review Comment: https://git.openjdk.org/jdk/pull/20930#discussion_r1753707545


More information about the core-libs-dev mailing list