RFR: 8339538: Wrong timeout computations in DnsClient [v6]

[Daniel Fuchs]

On Tue, 10 Sep 2024 18:41:41 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> This PR proposes the following changes to address wrong timeout computations in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano) clock. The existing `Timeout` test has also been updated to use the nano clock to measure observed timeout value.
>> 
>> - The left timeout computation has been fixed to decrease the timeout value during each retry attempt. A new test, `TimeoutWithEmptyDatagrams`, has been added to test it.
>> 
>> - The `DnsClient.blockingReceive` has been updated:
>>     - to detect if any data is received
>>     - to avoid contention with `Selector.close()` that could be called by a cleaner thread
>> 
>> - The expected timeout calculation in the `Timeout` test has been updated to take into account the minimum retry timeout (50ms). Additionally, the max allowed difference between the observed timeout and the expected one has been increased from 50% to 67%. Taking into account 50 ms retry timeout decrease the maximum allowed difference is effectively set to 61%. This change is expected to improve the stability of the `Timeout` test which has been seen to fail [intermittentlly](https://bugs.openjdk.org/browse/JDK-8220213). If no objections, I'm planning to close [JDK-8220213](https://bugs.openjdk.org/browse/JDK-8220213) as duplicate of this one.
>> 
>> JNDI/DNS jtreg tests has been executed multiple times (500+) to check if the new and the modified tests are stable. No failures been observed (so far?).
>
> Aleksei Efimov has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - update tests to calculate allowed timeout range (max is updated to 75%), print it and use it for elapsed time check
>  - remove redundant clamp from timeoutLeft calculation
>  - clamp timeout and retries property values

src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsContext.java line 185:

> 183:             int val = Integer.parseInt((String) propVal);
> 184:             if (retries != val) {
> 185:                 retries = Math.clamp(val, 1, 31);

Maybe we should rather use 30 here, since `1 << 1` is 2 and `1 << 31` is negative

src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsContext.java line 264:

> 262:         retries = (val == null)
> 263:             ? DEFAULT_RETRIES
> 264:             : Math.clamp(Integer.parseInt(val), 1, 31);

same remark herre

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1753832166
PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1753833767