RFR: 8339538: Wrong timeout computations in DnsClient [v5]

Daniel Fuchs dfuchs at openjdk.org
Wed Sep 11 16:30:10 UTC 2024


On Tue, 10 Sep 2024 19:01:54 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> I agree that we don't want to document too much here. Updated the factor to 1.75 (2 seems a bit high and might hide real issues), and to make the timeout value calculation and check less arcane - I have updated test output to print the range of acceptable timeout values: 05ed9e053865293a1938ed7bc6fe208759513813
>
> 2 time  is not too high,
> I have presented, in the comment, a failures with the elapsed time is almost twice the expected time
> where the elapsed time is 14229 !! which is approx 1.84 * expected timeout

@msheppar with the latest proposed change to set MIN_TIMEOUT to 0, then I believe the `@implNote` you suggested is no longer needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1755135496


More information about the core-libs-dev mailing list