RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v7]

fabioromano1 duke at openjdk.org
Thu Sep 12 12:45:06 UTC 2024


On Thu, 12 Sep 2024 12:21:59 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> So, a test should be done for every possible path of computation of `MBI.leftShift()` method...
>
> Looking at the code of `leftShift()` alone, I roughly count a dozen or so paths.
> But if you feel confident that the random tests cover all paths over several executions with high probability and that no corner cases are left out, then they might suffice.

I think that specific test cases for every path would make the code more reliable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1756784216


More information about the core-libs-dev mailing list