RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v7]

Brian Burkhalter bpb at openjdk.org
Thu Sep 12 15:43:12 UTC 2024


On Thu, 12 Sep 2024 06:24:50 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Thanks for making the changes. LGTM, assuming that tests still pass.

The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In any case, I will run another round of tests before integrating.

> src/java.base/unix/native/libjava/nio/fs/UnixNativeDispatcher.c line 221:
> 
>> 219: static futimesat_func* my_futimesat_func = NULL;
>> 220: static futimens_func* my_futimens_func = NULL;
>> 221: #ifndef _ALLBSD_SOURCE
> 
> This change looks unrelated. Was it intentional?

Yes. The variable on the next line `my_lutimes_func` caused an unused variable error in the macOS build.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20317#issuecomment-2346633671
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1757123250


More information about the core-libs-dev mailing list