RFR: 8338694: x86_64 intrinsic for tanh using libm [v4]

Andrey Turbanov aturbanov at openjdk.org
Fri Sep 13 09:30:18 UTC 2024


On Wed, 11 Sep 2024 00:29:30 GMT, Srinivas Vamsi Parasa <duke at openjdk.org> wrote:

>> The goal of this PR is to implement an x86_64 intrinsic for java.lang.Math.tanh() using libm
>> 
>> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
>> -- | -- | -- | --
>> MathBench.tanhDouble | 70900 | 95618 | 1.35x
>
> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   c1 and template generator fixes

test/jdk/java/lang/Math/HyperbolicTests.java line 1011:

> 1009:         }
> 1010: 
> 1011:         for(int i = 0; i < testCases.length; i++) {

Suggestion:

        for (int i = 0; i < testCases.length; i++) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20657#discussion_r1758522740


More information about the core-libs-dev mailing list