RFR: 8340131: Refactor internal makeHiddenClassDefiner to take ClassOption ... instead of Set

[Jorn Vernee]

On Fri, 13 Sep 2024 15:40:46 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Simple internal refactor to load a few classes less on startup. Arguably cleaner.

src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2223:

> 2221:             }
> 2222: 
> 2223:             return makeHiddenClassDefiner(bytes.clone(), false, options.clone())

Why do we need to clone here, but not for the method above? `makeHiddenClassDefiner` seems to always turn the options in flags right away, so I don't think we need to clone?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21002#discussion_r1759113533