RFR: 8340079: Modify rearrange/selectFrom Vector API methods to perform wrapIndexes instead of checkIndexes
Sandhya Viswanathan
sviswanathan at openjdk.org
Fri Sep 13 19:17:04 UTC 2024
On Fri, 13 Sep 2024 19:04:12 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> @jatin-bhateja If you could expand on this comment with specific cases it will be helpful. The loadShuffle generation is needed for platform specific handling of shuffles and cannot be optimized out here.
>
> Hi @sviswa7, I was suggesting emitting toShuffle() + toVector() only if it's needed under a target specific hook, since indexes are anyways passed though vector. Please let me know if you find blow explanation too constraining.
> https://github.com/openjdk/jdk/pull/20508#issuecomment-2349801299
I think VectorLoadShuffle removal optimizations should be a separate PR and well thought out. So far the contract has been that rearrange always gets the shuffle through VectorLoadShuffle and I would like to keep that contract in this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20634#discussion_r1759361459
More information about the core-libs-dev
mailing list