RFR: 8336025: Improve ZipOutputSream validation of MAX CEN Header field limits

Lance Andersen lancea at openjdk.org
Fri Sep 13 20:18:17 UTC 2024


Please review the following PR which addresses that ZipOutputStream should validate the CEN header fields similar to what was done via [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)

As part of this change, the javadoc for ZipEntry has been updated to indicate that the CEN Header(46 bytes) + entry name length + comment length + extra data length must not exceed 0xfffff.

Mach5 tiers 1-3 runs were clean.  The zip and jar JCK tests also continue to pass

-------------

Commit messages:
 - Improve ZipOuputSream validation of  MAX CEN Header field limits

Changes: https://git.openjdk.org/jdk/pull/21003/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21003&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8336025
  Stats: 223 lines in 4 files changed: 203 ins; 11 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/21003.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21003/head:pull/21003

PR: https://git.openjdk.org/jdk/pull/21003


More information about the core-libs-dev mailing list