RFR: 8339574: Behavior of File.is{Directory,File,Hidden} is not documented with respect to symlinks [v6]

Alan Bateman alanb at openjdk.org
Sat Sep 14 07:06:05 UTC 2024


On Fri, 13 Sep 2024 22:05:40 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and `isHidden` behave when the `File` represents a symbolic link.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8339574: Move symbolic link verbiage from class to constructor doc in FIS/FOS/RAF

src/java.base/share/classes/java/io/FileOutputStream.java line 103:

> 101:      * are automatically redirected to the <i>target</i> of the link.
> 102:      * If the file or link target exists, then it will be truncated.
> 103:      * A new {@code FileDescriptor} object is

This wording gives the impression that a link can be truncated :-)

I think the second sentence needs to say that it truncates an existing file, otherwise creates a new file. Then follow with the sentence on sym link behavior.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20878#discussion_r1759684286


More information about the core-libs-dev mailing list