RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v3]
Bernd
duke at openjdk.org
Sat Sep 14 16:18:04 UTC 2024
On Sat, 14 Sep 2024 13:14:35 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review for this change which cleans up the `java` launcher to remove checks/support for outdated options?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have been outdated and unsupported for several releases now. 2 of them even throw an error currently. The change in this PR removes the code which had specific checks for these options and will now consider these options just like any other unknown option to the launcher.
>>
>> tier1, tier2 and tier3 testing passed with these changes. Higher tier testing is in progress.
>>
>> Would this change require a CSR?
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> David's review - move -Xfuture to "Removed Java options"
BTW somewhat related, I always wondered if `-Xdiag` is still needed or can be better documented. For example it does not describe that it mainly modified the launcher diagnostic messages (and very little of them)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20945#issuecomment-2351048334
More information about the core-libs-dev
mailing list