RFR: 8340131: Refactor internal makeHiddenClassDefiner to take ClassOption ... instead of Set [v4]

[Chen Liang]

On Sat, 14 Sep 2024 01:12:47 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Simple internal refactor to load a few classes less on startup. Arguably cleaner.
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Unused import

src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 1912:

> 1910:                 int flags = 0;
> 1911:                 for (ClassOption cp : options) {
> 1912:                     flags |= cp.flag;

If we decide to throw IAE for duplicate flags, then we might have something like:

if ((flags & cp.flag) != 0)
    throw new IllegalArgumentException(); // Maybe a custom message

before this line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21002#discussion_r1759954092