RFR: 8340131: Refactor internal makeHiddenClassDefiner to take ClassOption ... instead of Set [v5]

Chen Liang liach at openjdk.org
Sun Sep 15 22:26:07 UTC 2024


On Sun, 15 Sep 2024 12:59:21 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Simple internal refactor to load a few classes less on startup. Arguably cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve edge invariant checks

If we leave this toctou, the main concern is racy duplicated elements. Then we should prefer to drop this duplication check at all, or do like my suggestion by checking in the bits.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21002#issuecomment-2351812806


More information about the core-libs-dev mailing list