RFR: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow

[Jaikiran Pai]

On Mon, 16 Sep 2024 01:21:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

> And it is a bit hard to track all the changes especially in relation to splashscreen.

If it helps, the webrev instead of the github UI might be better to review this change. Unless of course you were already using that one.

> src/java.base/share/native/libjli/java.c line 1345:
> 
>> 1343:             if (JLI_StrCCmp(arg, "-Djava.class.path=") == 0) {
>> 1344:                 _have_classpath = JNI_TRUE;
>> 1345:             } else if (JLI_StrCmp(arg, "-Djava.awt.headless=true") == 0) {
> 
> Was this processing moved from somewhere else?

Hello David, this was in the SelectVersion() method that we removed in this PR https://github.com/openjdk/jdk/pull/20997/files#diff-c3caaf3e347b1a477e2b7278cb6a35da04a597de5632c13351a6e4e5a2924d21L1154

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20997#issuecomment-2351893609
PR Review Comment: https://git.openjdk.org/jdk/pull/20997#discussion_r1760439200